Habit tracker#4
Conversation
DSills735
left a comment
DSills735
left a comment
There was a problem hiding this comment.
Hey, @laladrack 👋
I am here to perform a code review. Please fix anything marked 🔴 needs to be fixed to pass academy standards. I will add a few more comments of things I find as well, feel free to ignore or change those as you wish.
🔴 Upon cloning your repository and running the application, I am met with build failures, I will attatch some SS.
🟢 Without being able to fully debug/run the code, It does all look good!
🟡 I notice a few places in SQL commands you used string interpolation. For now, that is fine, but in the future better security measures will need to be taken. This is a risk for SQL injection.
🟡 I highly recommend you watch the unit testing tutorial, and get into the habit of creating tests early/often. I cannot stress how much time you will save refactoring in the future with a good testing suite.
That is all I noticed as of now. Again, please fix anything with 🔴. Thank you for the time you took to complete this project! I look forward to review your revisions. I will leave comments in the PR with my screenshots.
Thank you!
🔴 Build failure |
🔴 Build failure - I tried this first to make sure it wasnt my local machine causing the issue.
|
2 participants
Hello!
Please take a look at my Console Habit Tracker!
Any feedback is welcome :)